Skip to content

@remotion/studio: Broaden rotation regex to accept all CSS number forms#6946

Merged
JonnyBurger merged 1 commit intomainfrom
pullfrog/6943-broaden-rotation-regex
Mar 31, 2026
Merged

@remotion/studio: Broaden rotation regex to accept all CSS number forms#6946
JonnyBurger merged 1 commit intomainfrom
pullfrog/6943-broaden-rotation-regex

Conversation

@pullfrog
Copy link
Copy Markdown
Contributor

@pullfrog pullfrog bot commented Mar 31, 2026

Follow-up to #6943 — addresses review feedback.

Changes

  • Broadens the numeric regex to accept + signs (+720deg), bare decimals (.5deg), and trailing-dot forms (5.deg) — all valid CSS <number> representations
  • Consolidates the four separate unit regexes into a single shared unitPattern + unitToDegrees lookup, removing repetition

The old regex (-?\d+(?:\.\d+)?) would miss +720deg, causing it to fall through to the DOMMatrix path and return 0 — the exact bug the original PR was fixing.

Pullfrog  | View workflow run | Triggered by Pullfrog | Using Big Pickle (free) | 𝕏

@pullfrog pullfrog bot requested a review from JonnyBurger March 31, 2026 13:14
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment Mar 31, 2026 1:17pm
remotion Ready Ready Preview, Comment Mar 31, 2026 1:17pm

Request Review

@JonnyBurger JonnyBurger merged commit 3849482 into main Mar 31, 2026
18 of 19 checks passed
@JonnyBurger JonnyBurger deleted the pullfrog/6943-broaden-rotation-regex branch March 31, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant