fix: handle InputDisposedError in useWindowedAudioData to ensure prop…#6910
Merged
JonnyBurger merged 1 commit intoremotion-dev:mainfrom Mar 26, 2026
Merged
Conversation
…er rendering continuation
Contributor
There was a problem hiding this comment.
The fix is correct and consistent with the existing InputDisposedError handling elsewhere in the codebase (useMaxMediaDuration, fetchAndSetWaveformData, extract-frames.ts). Calling continueRender(handle) to release the delay render handle before returning is the right approach — and double-calling it (once from the abort listener, once from this catch) is safe since continueRenderInternal is idempotent.
Big Pickle (free) ｜ 𝕏
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the src changes, or the component unmounts, the metadata AbortController disposes the mediabunny Input while computeDuration() may still be running. That correctly throws InputDisposedError, but the catch path called cancelRender(err), which rethrows and produced an unhandled rejection because fetchMetadata is not awaited.
Treat InputDisposedError like the waveform path and useMaxMediaDuration: call continueRender(handle) and return; keep cancelRender for real failures.
Fixes #6894.