create-video: Respect npm registry config for corporate proxy support#6899
Merged
JonnyBurger merged 1 commit intoremotion-dev:mainfrom Mar 23, 2026
Merged
Conversation
…ing registry.npmjs.org Read the user's configured npm registry via `npm config get registry` so that create-video works behind corporate proxies and npm mirrors. Falls back to the default public registry if the command fails. Also adds a clear error message when the registry returns non-JSON (e.g. an HTML proxy page), guiding users to configure their registry. Closes remotion-dev#6888 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
LGTM. The implementation is clean and addresses issue #6888 well:
getRegistry()safely readsnpm config get registrywith a 10s timeout and falls back gracefully- Both
httpandhttpsregistries are supported via protocol detection - The error message is actionable and points users to the correct fix
One minor suggestion: The catch block on line 62 catches JSON parse errors, but this could also be a different kind of failure (though unlikely since the network call already succeeded). The current message is reasonable for the proxy case described in #6888.
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm config get registryinstead of hardcodingregistry.npmjs.orghttpandhttpsregistry URLsCloses #6888
Test plan
npm config set registry https://registry.npmjs.org→npx create-videoworks as beforenpm config set registry http://localhost:4873(Verdaccio) → uses the local registrySyntaxError: Unexpected token🤖 Generated with Claude Code