Recorder: Stop recording when tab sharing ends#6853
Merged
JonnyBurger merged 1 commit intomainfrom Mar 17, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Contributor
There was a problem hiding this comment.
The implementation is correct and handles the tab-sharing-end scenario well.
Key points:
- Idempotency pattern in
stopRecorder(cachingstoppedPromise) prevents race conditions when both the track-ended handler and React's cleanup effect try to stop the recorder - Moving
recorder.stop()after event listener setup ensures final data is captured before stopping - The
once: trueoption on track listeners correctly limits each listener to firing once
No issues found. This cleanly addresses issue #6844.
template-recorder: Stop recording when tab sharing ends
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MediaRecorderis stopped immediately in the trackendedevent handler (insidestartMediaRecorder) to prevent corrupt timestamps in the output filestopAndWaitUntilDoneis now idempotent — multiple calls return the same promise, so the React state transition inRecordButtonworks cleanly even though the recorder is already stoppedTest plan
🤖 Generated with Claude Code