remotion: Fix correct display of trimmed @remotion/media video#6850
Merged
JonnyBurger merged 1 commit intomainfrom Mar 17, 2026
Merged
remotion: Fix correct display of trimmed @remotion/media video#6850JonnyBurger merged 1 commit intomainfrom
remotion: Fix correct display of trimmed @remotion/media video#6850JonnyBurger merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
The fix looks correct. Adding trimBefore to videoConfig.durationInFrames compensates for the subtraction that calculateMediaDuration performs, ensuring the timeline displays the correct duration for trimmed videos.
The change is minimal and targeted. One suggestion: the PR body is empty — consider documenting what bug this fixes for future reference.
|
|
||
| const mediaDuration = calculateMediaDuration({ | ||
| mediaDurationInFrames: videoConfig.durationInFrames, | ||
| mediaDurationInFrames: videoConfig.durationInFrames + (trimBefore ?? 0), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.