Skip to content

@remotion/studio: Disable visual editing mode when server is disconnected#6706

Merged
JonnyBurger merged 2 commits intomainfrom
fix/visual-mode-disconnected
Feb 25, 2026
Merged

@remotion/studio: Disable visual editing mode when server is disconnected#6706
JonnyBurger merged 2 commits intomainfrom
fix/visual-mode-disconnected

Conversation

@JonnyBurger
Copy link
Copy Markdown
Member

Summary

  • When the studio server is disconnected, visual prop editing in the timeline is now disabled (expand arrows hidden, expanded sections not rendered), matching the behavior as if visual mode were off.
  • Previously, the UI would still show the visual editing controls but all API calls would fail silently, leading to a broken experience.

Closes #6671

Test plan

  • Start the studio with EXPERIMENTAL_VISUAL_MODE_ENABLED=true
  • Verify visual editing controls appear in the timeline for sequences with controls
  • Disconnect the studio server (e.g. stop the dev server) and verify the expand arrows and expanded sections disappear
  • Reconnect and verify visual editing controls reappear

Made with Cursor

…nected

When the studio server is disconnected, visual prop editing cannot work
because it relies on API calls to subscribe/save sequence props. This
treats visual mode as disabled when the server connection is not active,
preventing broken UI interactions.

Closes #6671

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment Feb 25, 2026 5:17pm
remotion Ready Ready Preview, Comment Feb 25, 2026 5:17pm

Request Review

Copy link
Copy Markdown
Contributor

@pullfrog pullfrog bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clean, well-targeted fix. The change correctly disables visual editing controls when the server is disconnected by checking previewServerState.type === 'connected' in addition to the environment variable.

The TimelineExpandedSection component makes API calls (/api/subscribe-to-sequence-props, /api/save-sequence-props) that would fail when disconnected, so hiding these controls prevents a confusing UX where buttons appear but don't work.

One minor observation: TimelineTracks.tsx also checks EXPERIMENTAL_VISUAL_MODE_ENABLED for rendering expanded track placeholders but doesn't include the server connection check. If a track is expanded when the server disconnects, TimelineTracks will still reserve placeholder space while TimelineListItem won't render the actual expanded content. This is a very minor edge case and not blocking—the PR as-is solves the main problem effectively.

Pullfrog  | Fix all ➔Fix 👍s ➔View workflow runpullfrog.com𝕏

@JonnyBurger JonnyBurger merged commit 3e260ab into main Feb 25, 2026
11 of 14 checks passed
@JonnyBurger JonnyBurger deleted the fix/visual-mode-disconnected branch February 25, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visual mode: Handle Studio server disconnection

1 participant