Skip to content

remotion.dev/convert: Allow to use it offline #4618

Merged
JonnyBurger merged 13 commits intoremotion-dev:mainfrom
Myestery:pwa-convert
Dec 12, 2024
Merged

remotion.dev/convert: Allow to use it offline #4618
JonnyBurger merged 13 commits intoremotion-dev:mainfrom
Myestery:pwa-convert

Conversation

@Myestery
Copy link
Copy Markdown
Contributor

@Myestery Myestery commented Dec 10, 2024

fix #4607
/claim #4607

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bugs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 10:56am
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 10:56am
remotion-convert ✅ Ready (Inspect) Visit Preview Dec 12, 2024 10:56am

@Myestery
Copy link
Copy Markdown
Contributor Author

Hi @JonnyBurger

I am almost done here, just the failing vercel build. I'll like to get logs for those if possible.
I had to touch the auto-select-writer file cos WebFs didn't work well on offline mode however the PWA works as expected using the Buffer fallback.

@JonnyBurger
Copy link
Copy Markdown
Member

Looking very nice so far!

These are the logs:

image

I don't know why that is but if you struggle, leave it, we'll take care of resolving it.

@Myestery
Copy link
Copy Markdown
Contributor Author

Looking very nice so far!

These are the logs:

image

I don't know why that is but if you struggle, leave it, we'll take care of resolving it.

okay, I'm a bit confused on how to replicate or fix this one so I'll need some help if its required to close the bounty

@JonnyBurger JonnyBurger changed the title setup PWA for convert package remotion.dev/convert: Allow to use offline Dec 12, 2024
@JonnyBurger
Copy link
Copy Markdown
Member

Awesome!

Thanks a lot, this is great 🤩

JonnyBurger
JonnyBurger previously approved these changes Dec 12, 2024
@JonnyBurger JonnyBurger changed the title remotion.dev/convert: Allow to use offline remotion.dev/convert: Allow to use it offline Dec 12, 2024
@Myestery
Copy link
Copy Markdown
Contributor Author

Myestery commented Dec 12, 2024

Hi @JonnyBurger, I noticed you moved the service worker js file to stay under /convert, I had issues with this approach cos the scope would then be /convert/* which excludes the /convert page itself.
So it didn't load offline

@JonnyBurger
Copy link
Copy Markdown
Member

It does seem to work for me, but I will revisit this when it is deployed, thank you!

image

@Myestery
Copy link
Copy Markdown
Contributor Author

Hi @JonnyBurger
Thanks for merging this, however the app still doesnt work without internet due to the issue I raised with the placement of the js file.
Most of the requests are supposed to be intercepted by the service worker but they are not

@JonnyBurger
Copy link
Copy Markdown
Member

thanks a lot for watching my fingers!

Trying to quick-fix it with 379f121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make remotion.dev/convert work offline using a Service Worker

2 participants