Skip to content

Adds @remotion/fonts package#3927

Merged
JonnyBurger merged 15 commits intoremotion-dev:mainfrom
enok1111:main
May 27, 2024
Merged

Adds @remotion/fonts package#3927
JonnyBurger merged 15 commits intoremotion-dev:mainfrom
enok1111:main

Conversation

@enok1111
Copy link
Copy Markdown
Contributor

/claim #3904

This pull request addresses the issue of creating a more user-friendly API for loading fonts in Remotion. The new loadFont() function simplifies the process and includes proper error handling, correct usage of url(), staticFile(), and format() values, and other necessary options.

Changes Implemented:

  • New function with the requested signature :
    loadFont() function added for simplified font loading.
  • Documentation:
    Main page for @remotion/fonts created.
    Detailed page for the loadFont() function with all options and usage examples added.
  • Tests:
    Added example Fonts composition in packages/example for testing loadFont().

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented May 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bugs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 5:54pm
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 5:54pm

JonnyBurger
JonnyBurger previously approved these changes May 27, 2024
Copy link
Copy Markdown
Member

@JonnyBurger JonnyBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did an excellent job!

Thanks a lot for implementing it! 🙌

@JonnyBurger JonnyBurger enabled auto-merge May 27, 2024 17:32
@vercel vercel bot temporarily deployed to Preview – bugs May 27, 2024 17:33 Inactive
@enok1111
Copy link
Copy Markdown
Contributor Author

You did an excellent job!

Thanks a lot for implementing it! 🙌

Thank you Jonny, for the fixes and approving it! 🙂
I really enjoyed this task and learned a lot.

@JonnyBurger JonnyBurger merged commit f2a8217 into remotion-dev:main May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New @remotion/fonts package with loadFont() function

2 participants