Return pixelFormat in getVideoMetadata()#3258
Merged
JonnyBurger merged 8 commits intoremotion-dev:mainfrom Dec 18, 2023
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
@JonnyBurger The tests on Windows always fail, and I've come across this code snippet. remotion/packages/renderer/build.mjs Lines 18 to 26 in d390b43 |
Member
|
It's ok, thats because we disable windows build right now because it is broken. no need to do anything! |
Member
|
Looks good, but I'll review it only by next week! |
Contributor
Author
|
No problem, have a great weekend! |
Member
|
Very well done! Thanks a lot and sorry for the long review time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #3216
/claim #3216