Skip to content

add showPlaybackControl to <Player />#2382

Merged
JonnyBurger merged 10 commits intoremotion-dev:mainfrom
il3ven:issue-2377
Jun 2, 2023
Merged

add showPlaybackControl to <Player />#2382
JonnyBurger merged 10 commits intoremotion-dev:mainfrom
il3ven:issue-2377

Conversation

@il3ven
Copy link
Copy Markdown
Contributor

@il3ven il3ven commented Jun 2, 2023

Closes #2377
/claim #2377

Checklist:

  • add showPlaybackControl which is false by default and optional
  • update packages/docs/docs/player/api.md
  • use pointerup instead of onclick
  • clicking outside closes the playback rate popup
  • ratechange event emitter is properly fired
  • updated player-example to have a showPlaybackControl toggle

`showPlaybackControl` will show an option to change playback rate on
the player.
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Jun 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2023 10:28am

@JonnyBurger JonnyBurger enabled auto-merge June 2, 2023 15:15
Copy link
Copy Markdown
Member

@JonnyBurger JonnyBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🙌🏼 This is pretty nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add playbackrate option to the player controls

2 participants