chore: verify middleware boundary enforcement in agent tools (#72)#73
Merged
alexey-pelykh merged 1 commit intomainfrom Feb 27, 2026
Merged
chore: verify middleware boundary enforcement in agent tools (#72)#73alexey-pelykh merged 1 commit intomainfrom
alexey-pelykh merged 1 commit intomainfrom
Conversation
Verification gate between gutting tasks (#66, #68, #70) and the final pi-embedded engine deletion. All 5 criteria pass: 1. Zero stray imports from deleted tool modules in KEEP code 2. 33 tool files match expected KEEP/DEFER inventory 3. No stray files found 4. agent-step.ts reclassified to KEEP (pure gateway, no pi-embedded coupling) 5. memory-tool.ts confirmed DEFER (no pi-embedded coupling) 6. pnpm build passes cleanly Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification gate between individual gutting tasks (#66, #68, #70) and the final pi-embedded engine deletion. Confirms the middleware boundary in
src/agents/tools/is correctly enforced.Verification Results
1. Zero references to deleted tool files in KEEP/MODIFY code
All searches return clean (excluding
pi-embedded-runner/as specified):web-fetch,web-search,web-shared,web-toolsbrowser-tool,image-tool,tts-toolsandboximportsbash-tools,exec-approvals,exec-safe-bin,exec-host,pty-dsr,pty-keys2. Only RemoteClaw-specific tools remain (33 files)
sessions-spawn-tool,sessions-send-tool,sessions-send-tool.a2a,sessions-send-helpers,sessions-list-tool,sessions-history-tool,sessions-access,sessions-resolution,sessions-announce-target,sessions-helpers,session-status-tooldiscord-actions(5),slack-actions,telegram-actions,whatsapp-actions,whatsapp-target-authgateway-tool,gateway,cron-tool,agents-list-toolmessage-tool,subagents-toolcommonnodes-tool,nodes-utils,canvas-toolagent-step,memory-tool3. No stray tool files
All 33 files accounted for. No unexpected files found.
4. Edge case resolutions
agent-step.ts-> Reclassified to KEEPcallGatewayRPC (chat.history,agent.wait)sessions-send-tool.a2a.ts,subagent-announce.ts,subagent-followup.tsmemory-tool.ts-> Confirmed DEFER, no pi-embedded couplingconfig,memory,routing,agents/agent-scope5. Build passes
pnpm buildcompletes with zero errors.Notable finding (deferred)
system-prompt.tshas ~50 lines of sandbox prompt generation (sandboxInfoparameter, lines ~490-534) that depend onEmbeddedSandboxInfofrompi-embedded-runner/types.ts. Also consumed byauto-reply/commands-system-prompt.tsviaresolveSandboxRuntimeStatus. Tightly coupled to pi-embedded engine -- should be cleaned up as part of engine deletion task, not this verification task.Test plan
agent-step.tshas zero pi-embedded importsmemory-tool.tshas zero pi-embedded importspnpm buildpasses with zero errorsCloses #72
🤖 Generated with Claude Code