docs: ice exec-approvals-architecture, refine middleware-arch boundary (#2618)#2619
Merged
alexey-pelykh merged 1 commit intomainfrom Apr 27, 2026
Conversation
12 tasks
#2618) Two doc-only changes anticipating the broader cleanup tracked in #2618: 1. ICED banner on docs/concepts/exec-approvals-architecture.md — the architecture described is not currently implemented (gateway handlers for exec.approval.{request,waitDecision,resolve} were deleted by PR #2375; macOS-mediated path is broken; verified by the audit doc at docs/refactor/exec-approval-singular-audit-2606.md from PR #2609). Status changed: Accepted → Iced. Doc preserved for historical context only; will be replaced when the new approach ships. 2. middleware-architecture.md § The Middleware Boundary Principle table gains a row clarifying the boundary for tool-approval routing: - LEFT (RemoteClaw): AgentRuntime tool-approval routing (capture and surface to channels) - RIGHT (Agent): Tool-execution decisions and the actual invocation post-approval Plus a clarifying paragraph: routing is RemoteClaw's because the user is reachable only via RemoteClaw's channel adapters (the "requires RemoteClaw infrastructure?" test is satisfied); tool execution itself remains the agent CLI's responsibility. The broader cleanup (gut 4 stranded callers + protocol declarations + tests) is in #2618. The chat-mediated AgentRuntime tool-approval routing implementation is in #2616 (referenced from the new boundary-table paragraph). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
a43666d to
7dd1f21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two doc-only changes anticipating the broader cleanup tracked in #2618:
ICED banner on
docs/concepts/exec-approvals-architecture.md— the architecture described is not currently implemented. The gateway handlers forexec.approval.{request,waitDecision,resolve}were deleted by PR gut: delete 8 zero-caller EXCLUDE-STUB files in src/gateway/ #2375 (2026-04-16); the macOS-mediated path is broken (verified by the audit in PR docs(audit): exec.approval.* (singular) wire-path broken — #2606 #2609 — seedocs/refactor/exec-approval-singular-audit-2606.md). Status changed: Accepted → Iced. Doc preserved for historical context only; will be replaced when the new approach ships. Banner links to Audit: exec-approvals request/decision/resolve subsystem registration survives a gut — wire-path or unregister #2606 (audit), Cleanup: gut singular exec.approval.* stranded surface (#2606 follow-up) #2618 (cleanup), AgentRuntime: route per-call tool approval requests to messaging channels #2616 (the new AgentRuntime tool-approval routing direction).docs/concepts/middleware-architecture.md§ The Middleware Boundary Principle table gains a row clarifying the boundary for tool-approval routing:Plus a clarifying paragraph: routing is RemoteClaw's because the user is reachable only via RemoteClaw's channel adapters (the "requires RemoteClaw infrastructure?" test is satisfied); tool execution itself remains the agent CLI's responsibility. Paragraph links to AgentRuntime: route per-call tool approval requests to messaging channels #2616 for implementation tracking.
Why now
The broader code cleanup (gut 4 stranded callers + protocol declarations + tests) is in #2618 and will land separately. The doc updates land here because:
exec.approval.*path being functionalTest plan
pnpm checkclean (format:check, tsgo, lint, lint:tmp:no-random-messaging, lint:no-remoteclaw-ai, lint:ui:no-css-class-drift) — ran via pre-commit hook🤖 Generated with Claude Code