fix(ci): relax appcast zero-items check — restore fork behavior#2396
Merged
alexey-pelykh merged 1 commit intomainfrom Apr 18, 2026
Merged
fix(ci): relax appcast zero-items check — restore fork behavior#2396alexey-pelykh merged 1 commit intomainfrom
alexey-pelykh merged 1 commit intomainfrom
Conversation
B8 DIFF-SYNC (#2395) inadvertently re-introduced upstream's strict `appcast.xml contains no <item> entries` validation, breaking the fork's publish-next workflow. Fork has a stub empty appcast.xml because macOS updates aren't published yet (per #2119, #6d51373c0e). The upstream validator in v2026.3.12 restored the strict check that was previously relaxed. Reverts just the zero-items error line from scripts/release-check.ts; preserves all other upstream improvements to the validator (new plugin-sdk required paths, collectForbiddenPackPaths extraction). Test: release-check.test.ts 9/9 pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix B8 post-merge CI regression
B8 DIFF-SYNC (#2395) inadvertently re-introduced upstream's strict
appcast.xml contains no <item> entriesvalidation inscripts/release-check.ts, breakingpublish-nexton main after merge.Why fork needs it relaxed: Fork has a stub empty
appcast.xmlbecause macOS app updates aren't published yet (see #2119 and6d51373c0e). The upstream validator in v2026.3.12 restored the strict check that the fork had intentionally relaxed.Change: Removes just the zero-items error line; preserves all other upstream improvements to the validator (new plugin-sdk required paths,
collectForbiddenPackPathsextraction).Test:
pnpm vitest run test/release-check.test.ts9/9 pass.Disposition:
scripts/release-check.tsshould be reclassified as EXTRACT inupstream/disposition.tsvto prevent future re-introduction.🤖 Generated with Claude Code