gut(onboard-auth): remove dead onboard-auth.* cluster (#2338)#2349
Merged
alexey-pelykh merged 1 commit intomainfrom Apr 13, 2026
Merged
gut(onboard-auth): remove dead onboard-auth.* cluster (#2338)#2349alexey-pelykh merged 1 commit intomainfrom
alexey-pelykh merged 1 commit intomainfrom
Conversation
Deletes the entire src/commands/onboard-auth.* cluster (13 files,
~3,500 LoC) — a parallel credential-management layer with zero
production callers. The live onboarding wizard
(src/wizard/onboarding.ts) writes credentials directly via
upsertAuthProfile in src/agents/auth-profiles.ts and never touches
any of these files.
Also sweeps the cascade dependency src/commands/zai-endpoint-detect.ts
(and its test) — the file imports four ZAI URL constants from the
deleted onboard-auth.models.ts and has no production callers, making
it dead after the cluster removal.
Deletions (15 files total):
- onboard-auth.ts (barrel)
- onboard-auth.config-core.ts
- onboard-auth.config-core.kilocode.test.ts
- onboard-auth.config-gateways.ts
- onboard-auth.config-litellm.ts
- onboard-auth.config-minimax.ts
- onboard-auth.config-opencode.ts
- onboard-auth.config-shared.ts
- onboard-auth.config-shared.test.ts
- onboard-auth.credentials.ts
- onboard-auth.models.ts
- onboard-auth.test.ts
- onboard-non-interactive.provider-auth.test.ts
- zai-endpoint-detect.ts (cascade)
- zai-endpoint-detect.test.ts (cascade)
Verification:
- git grep "onboard-auth" src/ → 0 hits
- git grep "from.*commands/onboard-auth" src/ → 0 hits
- pnpm check: format + tsgo + lint all clean
- pnpm test: 725 files, 6341 passed, 2 skipped, 0 failures
The Pi-era provider-stub cascade files (src/agents/{huggingface,
synthetic,together,venice}-models.ts, models-config.providers.ts,
src/secrets/provider-env-vars.ts) become orphaned after this change
and will be swept in the parallel sibling issue #2337.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2338.
Deletes the entire
src/commands/onboard-auth.*cluster — 13 files, ~3,500 LoC — plus 2 cascade files, totaling 15 files and 3,765 deletions. The cluster was a parallel credential-management layer with zero production callers. The live onboarding wizard (src/wizard/onboarding.ts) writes credentials directly viaupsertAuthProfileinsrc/agents/auth-profiles.tsand never touches any of these files.Deletions
Primary cluster (13 files, per issue body):
src/commands/onboard-auth.ts(barrel)src/commands/onboard-auth.config-core.tssrc/commands/onboard-auth.config-core.kilocode.test.tssrc/commands/onboard-auth.config-gateways.tssrc/commands/onboard-auth.config-litellm.tssrc/commands/onboard-auth.config-minimax.tssrc/commands/onboard-auth.config-opencode.tssrc/commands/onboard-auth.config-shared.tssrc/commands/onboard-auth.config-shared.test.tssrc/commands/onboard-auth.credentials.tssrc/commands/onboard-auth.models.tssrc/commands/onboard-auth.test.tssrc/commands/onboard-non-interactive.provider-auth.test.tsCascade (2 files, flagged as "Cascades Unlocked" in the issue):
src/commands/zai-endpoint-detect.ts— imports 4ZAI_*_BASE_URLconstants from the deletedonboard-auth.models.ts; zero production callers (only its own test)src/commands/zai-endpoint-detect.test.tsVerification
git grep \"onboard-auth\" src/→ 0 hitsgit grep \"from.*commands/onboard-auth\" src/→ 0 hitsgit grep \"zai-endpoint-detect\" src/→ 0 hitspnpm check(format + tsgo + lint) → cleanpnpm test→ 725 files, 6341 passed, 2 skipped, 0 failuresA fresh-context adversarial review dispatched as a
workflow-polishsubprocess independently verified symbol-level grep for every export (writeOAuthCredentials,applyOnboardAuthAgentModelsAndProviders, all 20apply*Configfunctions, all 22set*ApiKeysetters,build*ModelDefinitionhelpers,detectZaiEndpoint,resolveZaiBaseUrl) — all zero hits. The live onboarding path viasrc/wizard/onboarding.tswas confirmed to reachupsertAuthProfilewithout touching any deleted file.Sibling Coordination
src/agents/{huggingface,synthetic,together,venice}-models.ts,src/agents/models-config.providers.ts, andsrc/secrets/provider-env-vars.ts. This PR does not touch any of them — they become orphaned here and will be swept there.onboard-provider-auth-flags.ts. Not touched here.Out of Scope
remoteclaw onboardwizard smoke test (from issue AC) — recommended to run manually before merge, though no middleware code is touched soLIVE=1 pnpm test:liveis not required by the project CI gate.Test Plan
pnpm installpnpm canvas:a2ui:bundlepnpm check(format + tsgo + lint)pnpm testremoteclaw onboardwizard end-to-end (recommended pre-merge)