gut(cli): remove dead memory CLI (#2300)#2326
Merged
alexey-pelykh merged 1 commit intomainfrom Apr 12, 2026
Merged
Conversation
The memory subsystem was gutted in the middleware fork (agents bring own memory), but `src/cli/memory-cli.ts` and its test survived — they imported from the gutted `src/memory/` module via an allowlist escape in `check-no-zombie-imports.mjs`. - Delete `src/cli/memory-cli.ts` (819 lines) - Delete `src/cli/memory-cli.test.ts` (572 lines) - Remove stale allowlist entries pointing at the deleted file `register.subclis.ts` already had no `memory` entry (removed in #187), so it is untouched to avoid conflict with the in-flight stub sweep (#2303). The orphaned `getMemoryCommandSecretTargetIds` helper in `command-secret-targets.ts` is left for #2303. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2300. Removes the dead memory CLI that survived the middleware-fork gut of the memory subsystem.
src/cli/memory-cli.ts(819 lines) — imported from the guttedsrc/memory/module via an allowlist escape.src/cli/memory-cli.test.ts(572 lines) — tests only the deleted file.scripts/check-no-zombie-imports.mjs. The script's own docstring instructs this cleanup ("Remove entries as the underlying imports are eliminated").Total: 1,393 deletions.
Coordination with other MBP audit items
src/cli/program/register.subclis.tsis not touched — it already has nomemoryentry (removed in fix: delete dead code survivors from pre-rebrand audit #187). Avoids conflict with the in-flight stub sweep (gut: sweep gutted stubs across agents, auto-reply, commands, cli (MBP audit) #2303) which edits this file in the next wave.getMemoryCommandSecretTargetIdshelper insrc/cli/command-secret-targets.tsis left for gut: sweep gutted stubs across agents, auto-reply, commands, cli (MBP audit) #2303 (stub sweep) since it lives in a shared file with other live exports.Acceptance criteria (from #2300)
grep -r "memory-cli" src/cli/returns nothinggrep -r "from.*memory" src/cli/returns no live importspnpm check: format + tsgo + oxlint)pnpm test: 745 files, 6482 tests passed, 2 skipped)Test plan
pnpm checkcleanpnpm testgreen (745 files, 6482 tests passing)Follow-ups (not in this PR)
🤖 Generated with Claude Code