gut(routing): replace routing fallback with explicit failure#2285
Merged
alexey-pelykh merged 1 commit intomainfrom Apr 11, 2026
Merged
gut(routing): replace routing fallback with explicit failure#2285alexey-pelykh merged 1 commit intomainfrom
alexey-pelykh merged 1 commit intomainfrom
Conversation
Replace the silent default-agent fallback in resolveAgentRoute() with explicit sole-agent auto-selection and error routes: - Rewrite pickFirstExistingAgentId() → resolveExistingAgentId() that returns null when an agent ID is not found in config (no silent remap) - Single-agent config with no binding match → auto-route to sole agent (matchedBy: "sole-agent") - Multi-agent config with no binding match → error route with guidance - Binding referencing unknown agent ID → error route (not silent remap) - Remove "default" from matchedBy union, add "sole-agent" | "error" - Add error field to ResolvedAgentRoute for config guidance messages - Update all test configs to include agents list where routing is used Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveAgentRoute()with explicit sole-agent auto-selection and error routespickFirstExistingAgentId()→resolveExistingAgentId()that returnsnullwhen an agent ID is not found in config (no more silent remap to default)matchedBy: "sole-agent"); multi-agent config with no binding match → returns error route with config guidanceCloses #1576
Test plan
tsgo --noEmit)oxlint --type-aware: 0 warnings, 0 errors)oxfmt --check)🤖 Generated with Claude Code