gut(commands): remove dead model/thinking/exec infrastructure and stop command#2280
Merged
alexey-pelykh merged 1 commit intomainfrom Apr 11, 2026
Merged
Conversation
…p command (#2134) Remove non-functional model directive parser, thinking/reasoning/elevated level types and normalization, dead InlineDirectives type fields, stop command registry entry with stub handlers, and dead help text references. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
64f84f9 to
6300b4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove dead model/thinking/reasoning/elevated/exec infrastructure — inline directive type fields, model directive parser, thinking-level types and normalization, help text references, and the
stopcommand registry entry with its stub handlers.Closes #2134
What was removed
model.ts) and its tests —extractModelDirective()ran during parse but result was never acted onThinkLevel,ElevatedLevel,ReasoningLevel) and their normalization functions — CLI agents manage their own thinking/reasoning levelsInlineDirectivesfields —hasModelDirective,hasThinkDirective,hasReasoningDirective,hasElevatedDirective,hasExecDirectiveand associated data fields (never populated to true)directive-handling.levels.ts— resolved current think/reasoning/elevated levels from session (dead without the types)stopcommand — registry entry +handleStopCommand/handleAbortTriggerstub handlers (real abort mechanism inabort.tsis untouched)/compact,/stop,/think,/model,/context,/skillremoved frombuildHelpMessage()What was kept
VerboseLevel,normalizeVerboseLevel,NoticeLevel,normalizeNoticeLevel,UsageDisplayLevel,normalizeUsageDisplay,resolveResponseUsageMode— alive infrastructureInlineDirectivesabort.tsandabort-cutoff.ts— real abort mechanismTelegramReasoningLeveltype — separate local typeFiles affected
Test plan
pnpm buildsucceedspnpm testpasses (693 files, 5923 tests)pnpm checkpasses (format + typecheck + lint)🤖 Generated with Claude Code