gut(models): remove vestigial model catalog, vision check, and thinking default stubs#2276
Merged
alexey-pelykh merged 1 commit intomainfrom Apr 11, 2026
Merged
Conversation
…ng default stubs (#2151) Delete model-catalog.ts, model-selection.ts, and auto-reply/reply/model-selection.ts stub files. Rewire all importers — simplify callers that consumed no-op return values, redirect parseModelRef to provider-utils.ts, rewire sanitizeUserFacingText and text strip functions to their live implementations in agent-helpers/agent-utils. Remove loadGatewayModelCatalog from GatewayRequestContext, normalizeDeviceMetadataForAuth stub and its callers, canvas/plugin auth stubs in server-http.ts, and all test mocks for the deleted modules (~12 test files). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2151
model-catalog.ts,model-selection.ts,auto-reply/reply/model-selection.tsparseModelRefimport in live test to canonicalprovider-utils.tssanitizeUserFacingTextand text strip functions to live implementations inagent-helpers/agent-utilsloadGatewayModelCatalogfromGatewayRequestContexttype and all pass-throughsnormalizeDeviceMetadataForAuthstub — inline raw values in callersserver-http.ts(always pass-through)__resetModelCatalogCacheForTestexport chain36 files changed, 98 insertions, 746 deletions.
Test plan
pnpm checkpasses (format + typecheck + lint)pnpm test— 693 test files, 5926 tests pass🤖 Generated with Claude Code