Skip to content

chore: delete 31 zero-importer DIFF-SYNC stub files#2262

Merged
alexey-pelykh merged 1 commit intomainfrom
chore/audit-diff-sync-stubs
Apr 11, 2026
Merged

chore: delete 31 zero-importer DIFF-SYNC stub files#2262
alexey-pelykh merged 1 commit intomainfrom
chore/audit-diff-sync-stubs

Conversation

@alexey-pelykh
Copy link
Copy Markdown

Summary

Audits all 59 DIFF-SYNC stub files (<=20 lines, marked "Gutted in RemoteClaw fork") created during batches B1-B4 and deletes the 31 that have zero importers.

  • 31 deleted: Zero alive imports — safe to remove with no cascading effects
  • 28 retained: Have real importers from alive infrastructure (commands, config, gateway, discord, plugins)
  • Build: tsc --noEmit passes, no new test failures introduced
  • Fork invariants: All architecture, identity, config schema, and test infra invariants verified

Retained stubs (28) — documented for future cleanup

Domain Count Key stubs Reason
src/config/ 6 sessions.ts (barrel, 147 importers), types.{sandbox,acp,memory,skills}, normalize-exec-safe-bin Core config infrastructure depends on exports
src/agents/ 6 context, defaults, model-fallback, models-config.providers, sandbox/network-mode, skills-status Status/session commands need default values
src/infra/ 6 exec-safety, exec-command-resolution, exec-safe-bin-{policy,runtime-policy,trust}, skills-remote Doctor config flow + gateway ws-connection
src/commands/ 1 auth-choice.apply-helpers Onboarding/channel plugin helpers
src/cli/ 2 command-secret-{gateway,targets} Status-all + channel resolve commands
src/memory/ 2 index, internal memory-cli.ts (820 lines, itself orphanable)
Other 5 browser/form-fields, discord/thread-bindings.messages, media-understanding/transcribe-audio, agents/tools/memory-tool, config/sessions/types Various alive importers

Disposition registry (HQ)

Added 4 missing entries to upstream/disposition.tsv:

  • EXCLUDE src/acp/control-plane/manager.ts
  • EXCLUDE src/agents/bootstrap-cache.ts
  • EXCLUDE src/infra/exec-safety.ts
  • EXTRACT src/config/sessions.ts

Test plan

  • tsc --noEmit — zero errors
  • vitest run — 1374 passed, 3 failed (all pre-existing)
  • Fork invariants checklist — all pass
  • No new vi.mock or import references to deleted files break

Closes #2192

🤖 Generated with Claude Code

Remove 31 stub files (marked "Gutted in RemoteClaw fork") that were
created during DIFF-SYNC batches B1-B4 to satisfy imports that no
longer exist. Each stub has zero importers — no alive code depends
on them.

Deleted stubs by domain:
- src/acp/ (2): control-plane/manager, policy
- src/agents/ (14): auth-profiles/session-override, bootstrap-cache,
  cli-runner, context-window-guard, huggingface-models,
  pi-embedded-runner/run/params, pi-model-discovery, skills,
  skills/refresh, synthetic-models, together-models, venice-models
- src/commands/ (10): auth-choice.apply.{anthropic,byteplus,
  huggingface,volcengine}, auth-token, doctor-memory-search,
  doctor-sandbox, model-picker, models, onboard-skills
- src/gateway/ (4): exec-approval-manager,
  server-methods/exec-approval, test-helpers.openai-mock,
  test-openai-responses-model
- src/infra/ (1): system-run-approval-binding
- src/memory/ (1): status-format
- src/sessions/ (1): model-overrides

28 stubs with real importers are retained — documented in #2192.

Closes #2192

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@alexey-pelykh alexey-pelykh merged commit 939b1cb into main Apr 11, 2026
10 checks passed
@alexey-pelykh alexey-pelykh deleted the chore/audit-diff-sync-stubs branch April 11, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit and eliminate DIFF-SYNC stub files (59 disposition misclassifications)

1 participant