Skip to content

feat(doctor,acp,routes): re-apply remaining medium-priority upstream improvements (#2208)#2258

Merged
alexey-pelykh merged 1 commit intomainfrom
feat/2208-reapply-medium-upstream-improvements
Apr 10, 2026
Merged

feat(doctor,acp,routes): re-apply remaining medium-priority upstream improvements (#2208)#2258
alexey-pelykh merged 1 commit intomainfrom
feat/2208-reapply-medium-upstream-improvements

Conversation

@alexey-pelykh
Copy link
Copy Markdown

Summary

Re-applies 5 medium-priority upstream improvements from v2026.3.1/v2026.3.2 that were lost during PR #2191 wholesale file restoration.

Closes #2208

Applied (5 of 7)

  • doctor.ts: Import + call noteStartupOptimizationHints() — startup optimization doctor check (module doctor-platform-notes.ts exists)
  • doctor.ts: Import + call noteOpenAIOAuthTlsPrerequisites() — OpenAI OAuth TLS prerequisites check (module oauth-tls-preflight.ts exists)
  • routes.ts: Conditional loadPlugins for health --json — changes type from boolean to boolean | function, skips local plugin metadata loading for JSON health checks (consumer at route.ts already handles function type)
  • acp/client.ts: Wire resolveAcpClientSpawnInvocation into createAcpClient — function existed but was unused; enables Windows .cmd shim handling and windowsHide
  • doctor-legacy-config.ts: Replace inline Slack migration message strings with formatSlackStreamModeMigrationMessage() / formatSlackStreamingBooleanMigrationMessage() from discord-preview-streaming.ts (DRY refactor)

Skipped (2 of 7)

  • config/defaults.ts cacheRetention: "short" — already present in current code (lines 291-324)
  • sessions.ts CONTROL_UI filter — not present in upstream v2026.3.1/v2026.3.2 diffs (fdcbc3bd86~1..0241706c9d); the improvement is not attributable to the B3/B4 sync

Test plan

  • TypeScript type-check passes (zero errors in changed files)
  • Lint passes (oxlint --type-aware: 0 warnings, 0 errors)
  • Format check passes
  • All 694 test files pass (5949 tests)
  • CI passes (build + test + lint + docs)

🤖 Generated with Claude Code

…improvements (#2208)

Re-apply 5 upstream improvements from v2026.3.1/v2026.3.2 that were
lost during PR #2191 wholesale file restoration:

- doctor.ts: import + call noteStartupOptimizationHints()
- doctor.ts: import + call noteOpenAIOAuthTlsPrerequisites()
- routes.ts: conditional loadPlugins for health --json — skip plugin
  preload when JSON output requested
- acp/client.ts: wire resolveAcpClientSpawnInvocation into
  createAcpClient — enables Windows .cmd shim handling and windowsHide
- doctor-legacy-config.ts: replace inline Slack migration messages
  with shared formatSlackStream*() formatters from
  discord-preview-streaming.ts

Skipped (already present or not in upstream B3/B4 diffs):
- config/defaults.ts cacheRetention: "short" — already in current code
- sessions.ts CONTROL_UI filter — not present in upstream B3/B4 commits

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@alexey-pelykh alexey-pelykh enabled auto-merge (squash) April 10, 2026 23:11
@alexey-pelykh alexey-pelykh merged commit 536e43b into main Apr 10, 2026
10 checks passed
@alexey-pelykh alexey-pelykh deleted the feat/2208-reapply-medium-upstream-improvements branch April 10, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-apply remaining medium-priority v2026.3.1/v2026.3.2 improvements

1 participant