feat(doctor): re-apply doctor-config-flow upstream improvements (#2204)#2256
Merged
alexey-pelykh merged 1 commit intomainfrom Apr 10, 2026
Merged
Conversation
…v2026.3.1/v2026.3.2 (#2204) Re-apply ~400 LoC of upstream diagnostic and repair features lost during PR #2191 wholesale restoration. All dependency modules exist in the fork. Feature groups re-applied: 1. noteOpencodeProviderOverrides — replace no-op stub with real implementation detecting OpenCode Zen provider overrides 2. collectMissingDefaultAccountBindingWarnings — new channel-layer diagnostic warning when accounts lack default/binding coverage 3. Exec safe-bin profile scaffolding — 3 types + 6 functions (normalizeConfiguredSafeBins, collectExecSafeBinScopes, scanExecSafeBinCoverage, scanExecSafeBinTrustedDirHints, maybeRepairExecSafeBinProfiles, normalizeConfiguredTrustedSafeBinDirs) 4. "Legacy" to "Compatibility" terminology rename (3 occurrences) 5. formatConfigIssueLines usage from dedicated issue-format module 6. Supporting imports (isRecord, formatConfigIssueLines, exec-safe-bin modules) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-apply ~400 LoC of upstream diagnostic and repair features to
doctor-config-flow.tsthat were lost during PR #2191 wholesale restoration from pre-v2026.3.1. Builds on top of PR #2254 which already re-appliedmaybeRepairAllowlistPolicyAllowFrom,detectEmptyAllowlistPolicy, andhasAllowFromEntries.6 feature groups re-applied:
noteOpencodeProviderOverrides— Replace no-op stub with real implementation that detects when OpenCode Zen provider overrides mask built-in routing/costscollectMissingDefaultAccountBindingWarnings— New exported diagnostic function +normalizeBindingChannelKeyhelper. Warns when channels have accounts configured but no default account and no binding coveragenormalizeConfiguredSafeBins,normalizeConfiguredTrustedSafeBinDirs,collectExecSafeBinScopes,scanExecSafeBinCoverage,scanExecSafeBinTrustedDirHints,maybeRepairExecSafeBinProfiles. Imports from existing gutted stub modules (exec-command-resolution,exec-safe-bin-runtime-policy,exec-safe-bin-trust)loadAndMaybeMigrateDoctorConfigformatConfigIssueLinesusage — Replace 2 inline.map()formatting calls with sharedformatConfigIssueLines()fromconfig/issue-format.jsisRecordfrom utils,formatConfigIssueLinesfrom config/issue-format, 6 exec-safe-bin functions from 3 infra modulesCall sites added to
loadAndMaybeMigrateDoctorConfig:collectMissingDefaultAccountBindingWarnings(candidate)— after autoEnable, before repair/scan branchmaybeRepairExecSafeBinProfiles(candidate)— in repair branch, after toolsBySenderRepairscanExecSafeBinCoverage(candidate)+scanExecSafeBinTrustedDirHints(candidate)— in scan/else branch, after toolsBySenderHitsCloses #2204
Test plan
pnpm check)🤖 Generated with Claude Code