Skip to content

ci: add zombie-import gate — detect imports from gutted modules#2247

Merged
alexey-pelykh merged 1 commit intomainfrom
ci/zombie-import-gate
Apr 10, 2026
Merged

ci: add zombie-import gate — detect imports from gutted modules#2247
alexey-pelykh merged 1 commit intomainfrom
ci/zombie-import-gate

Conversation

@alexey-pelykh
Copy link
Copy Markdown

Summary

  • Adds scripts/check-no-zombie-imports.mjs — a CI gate that detects imports (static, re-export, dynamic import(), and typeof import()) from gutted modules: pi-embedded, model-catalog, model-fallback, model-selection, skills, sandbox, pi-embedded-runner, memory/, acp/control-plane, acp/runtime
  • Adds zombie-import-gate job to CI workflow, required to pass alongside rebrand-gate, lint, build, and test
  • 17 existing legacy callsites are allowlisted for incremental cleanup (see Audit and eliminate DIFF-SYNC stub files (59 disposition misclassifications) #2192)

Closes #2195

Test plan

  • Gate passes locally with allowlisted violations (exit 0)
  • Detection verified on known zombie imports: static, re-export, dynamic import(), typeof import()
  • Clean files (e.g. acp-cli.ts with acp/client — not in dead list) produce no false positives
  • Commented-out imports correctly ignored (AST-based, not regex)
  • Format and lint checks pass
  • CI zombie-import-gate job passes

🤖 Generated with Claude Code

Adds a CI check that prevents imports from known-dead modules
(pi-embedded, model-catalog, model-selection, skills, sandbox,
memory, acp/runtime, etc.) from silently re-entering the codebase.

Existing legacy callsites are allowlisted for incremental cleanup.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@alexey-pelykh alexey-pelykh merged commit 1fa1737 into main Apr 10, 2026
10 checks passed
@alexey-pelykh alexey-pelykh deleted the ci/zombie-import-gate branch April 10, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CI zombie-import gate: detect imports from gutted modules

1 participant