fix(heartbeat): restore file-based prompt resolution and workspace dir#2246
Merged
alexey-pelykh merged 1 commit intomainfrom Apr 10, 2026
Merged
fix(heartbeat): restore file-based prompt resolution and workspace dir#2246alexey-pelykh merged 1 commit intomainfrom
alexey-pelykh merged 1 commit intomainfrom
Conversation
#2194) Restore the file-based heartbeat prompt resolution that was lost during workspace cleanup (WI-179) and DIFF-SYNC. Pre-B3, resolveHeartbeatPrompt accepted { prompt, file, workspaceDir } and could load prompts from a file path relative to the agent workspace — the current version only accepted a raw string. Changes: - Add `file` field to HeartbeatSchema and HeartbeatConfig type - Restore async resolveHeartbeatPrompt with file + workspaceDir support - Wire resolveAgentWorkspaceDir into heartbeat-runner prompt resolution - Update resolveHeartbeatSummaryForAgent to show [file: ...] indicator - Update web heartbeat-runner for new async signature - Update tests with file-based resolution coverage Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filefield toHeartbeatSchemaandHeartbeatConfigtype so heartbeat prompts can be loaded from a file path relative to the agent workspaceresolveHeartbeatPromptto async with{ prompt, file, workspaceDir }options —prompttakes precedence,fileis read at runtime, gracefully falls back on missing/empty filesresolveAgentWorkspaceDirinto the heartbeat-runner prompt resolution pipelineresolveHeartbeatSummaryForAgentto show[file: ...]indicator in the summary when file-based prompt is configuredCloses #2194
Test plan
resolveHeartbeatPrompttests: empty, whitespace, trimmed prompt, prompt precedence over file, file reading, absolute paths, missing files, empty file contentpnpm checkgreen)🤖 Generated with Claude Code