macOS: remove dead skills UI and model catalog code#220
Merged
alexey-pelykh merged 1 commit intomainfrom Mar 4, 2026
Merged
Conversation
Delete SkillsSettings, SkillsModels, ModelCatalogLoader and their tests. Remove skills tab from settings, skills overview from onboarding ready page, skills gateway methods from GatewayConnection, model catalog UI from DebugSettings, and related constants. Stub SkillBinsCache.refresh() to return empty bins since the gateway no longer exposes skills.* RPC. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #123.
SkillsSettings.swift(621 lines),SkillsModels.swift(74 lines),ModelCatalogLoader.swift(160 lines) and their testsSettingsRootView, skills overview from onboardingreadyPage()skillsStatus/skillsInstall/skillsUpdatefromGatewayConnection.Methodenum and convenience methodsDebugSettings(AppStorage bindings, GridRow, chooseCatalogFile/reloadModels functions)modelCatalogPathKey/modelCatalogReloadKeyfromConstants.swiftSkillBinsCache.refresh()to return empty bins (gateway no longer exposesskills.*RPC)SkillsSettings13 files changed, 3 insertions, 1,263 deletions. macOS only.
Verification
swift buildpassesswift build --build-testspassesSkillsSettings,SkillsModels,ModelCatalogLoader,skillsStatus,skillsInstall,skillsUpdate,modelCatalogPathKey,modelCatalogReloadKey) in remaining sourceDeviceModelCatalog(device name mapping) is correctly preservedTest plan
swift buildcompiles cleanlyswift build --build-testscompiles test targets🤖 Generated with Claude Code