gut(providers): collapse isCliProvider hardcoded *-cli checks into CLI_RUNTIME_NAMES#2152
Merged
alexey-pelykh merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
…I_RUNTIME_NAMES (#2125) Remove hardcoded `"claude-cli"` and `"codex-cli"` special-case branches from `isCliProvider()`, `getCliSessionId()`, `setCliSessionId()`, and the session expiration handler in `agent.ts`. After #2108 all callers pass bare runtime names, making the `-cli` suffixed paths dead code. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2125
"claude-cli"and"codex-cli"special-case branches fromisCliProvider()— bare runtime names viaCLI_RUNTIME_NAMESare now the only path"claude-cli"legacy fallback fromgetCliSessionId()and dual-write fromsetCliSessionId()incli-session.tsproviderOverride === "claude-cli"→claudeCliSessionIdcleanup from the session expiration handler inagent.ts-clisuffixed names now returnfalsefromisCliProvider(); legacyclaudeCliSessionIdtest cases removedTest plan
pnpm checkpasses (format + typecheck + lint)isCliProvider("claude")→true,isCliProvider("claude-cli")→false🤖 Generated with Claude Code