gut(session): remove resolveDefaultModel and simplify provider flow#2132
Merged
alexey-pelykh merged 1 commit intomainfrom Apr 8, 2026
Merged
gut(session): remove resolveDefaultModel and simplify provider flow#2132alexey-pelykh merged 1 commit intomainfrom
alexey-pelykh merged 1 commit intomainfrom
Conversation
…2108) Delete resolveDefaultModel() and replace the provider/model/aliasIndex plumbing with a single runtimeId sourced from resolveAgentRuntime(). This removes the last vestiges of the upstream model selection chain from the auto-reply flow — CLI runtimes own model selection. - Delete resolveDefaultModel and its test suite - Remove defaultProvider/defaultModel/aliasIndex from get-reply.ts - Remove provider/model/defaultProvider/defaultModel from RunPreparedReplyParams - Remove heartbeat model override parsing (parseModelRef call) - Remove channel model override from get-reply flow - Remove model directive persistence from persistInlineDirectives - Simplify reset session notice to show runtimeId - Thread runtimeId through directive chain as single identifier Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2108
resolveDefaultModel()and its test suite fromdirective-handling.persist.tsdefaultProvider/defaultModel/aliasIndexplumbing inget-reply.tswith a singleruntimeIdfromresolveAgentRuntime()provider/model/defaultProvider/defaultModelfromRunPreparedReplyParamsparseModelRefcall) and channel model override from the get-reply flowpersistInlineDirectivesruntimeIdthrough the directive chain as the single session identifier13 files changed, 60 insertions, 332 deletions.
Test plan
pnpm checkpasses (format + typecheck + lint: 0 errors)grep -w resolveDefaultModelreturns no resultsget-reply.tsuses singleruntimeIdflow from config to session usage🤖 Generated with Claude Code