You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DEFERRED — see Revisit Conditions below. Tracked for visibility, not actively scheduled.
Problem (when revisited)
Even after the Phase 1-2 child issues of #2433 (AST gate, baselines, attestation manifest) land, there may remain a residual class of regression where mocks diverge from real implementations in ways that none of those gates detect (e.g., return-shape mismatches that are syntactically valid). Mock ablation — running the test suite both with and without fork-boundary mocks — would catch any such divergence empirically.
Proposed solution (when revisited)
Second Vitest config (vitest.ablation.config.ts) with setupFiles that monkey-patches vi.mock to no-op for configured fork-boundary modules. CI runs full suite both normally and ablated; tests that fail without the mock are candidates for review. Initially non-blocking, promoted to blocking on sync PRs only.
Why deferred
High initial triage cost — sample test (src/cron/isolated-agent/run.auth-retry.test.ts) mocks 8 functions of agent-scope plus 7 other modules. Ablating these surfaces hundreds of legitimate "needs-mock-because-X" cases (subprocess spawning, filesystem I/O, network).
Status
DEFERRED — see Revisit Conditions below. Tracked for visibility, not actively scheduled.
Problem (when revisited)
Even after the Phase 1-2 child issues of #2433 (AST gate, baselines, attestation manifest) land, there may remain a residual class of regression where mocks diverge from real implementations in ways that none of those gates detect (e.g., return-shape mismatches that are syntactically valid). Mock ablation — running the test suite both with and without fork-boundary mocks — would catch any such divergence empirically.
Proposed solution (when revisited)
Second Vitest config (
vitest.ablation.config.ts) withsetupFilesthat monkey-patchesvi.mockto no-op for configured fork-boundary modules. CI runs full suite both normally and ablated; tests that fail without the mock are candidates for review. Initially non-blocking, promoted to blocking on sync PRs only.Why deferred
src/cron/isolated-agent/run.auth-retry.test.ts) mocks 8 functions ofagent-scopeplus 7 other modules. Ablating these surfaces hundreds of legitimate "needs-mock-because-X" cases (subprocess spawning, filesystem I/O, network).Revisit when
Effort (estimated when revisited)
2-4 days bootstrap + ongoing 0.5-1 day/quarter curation.
Dependencies
Tracked under: #2433
Revisit-after: attestation manifest lands and 1-2 sync cycles validate it
References
/evaluateanalysis: full deep-dive in evaluation report (2026-04-19 conversation)