feat(remix-node): replace extended classes for NodeRequest & NodeResponse with interface type casts#7109
Merged
Merged
Conversation
…onse with interface type casts Co-authored-by: jeeyoungk Co-authored-by: Michaël De Boey <info@michaeldeboey.be> Co-authored-by: Jacob Ebey <jacob.ebey@live.com>
🦋 Changeset detectedLatest commit: 948d7c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks
NodeRequest & NodeResponse with interface type casts
This was referenced Aug 9, 2023
Contributor
|
🤖 Hello there, We just published version Thanks! |
Contributor
|
🤖 Hello there, We just published version Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retarget to dev of #7069, credit to @jeeyoungk
Closes #3480
Closes #4148
Closes #4395
Closes #7059
This is a fix for the referenced issue; The fix is by
NodeRequestandNodeResponseclasses with interfaces.new NodeRequestorx instanceof NodeRequest). For this purpose,WebRequestandWebResponseare exposed as classes.This code is quite tricky as we're exporting types and values separately. The correct way of doing this is to define a type and value with the same identifier,
exporthandles this correctly.Testing Strategy: new integration and unit tests