Skip to content

ci: prerelease test infrastructure#1408

Merged
kentcdodds merged 118 commits into
devfrom
logan/rem-656-netlify-prerelease-test
Jan 14, 2022
Merged

ci: prerelease test infrastructure#1408
kentcdodds merged 118 commits into
devfrom
logan/rem-656-netlify-prerelease-test

Conversation

@mcansh

@mcansh mcansh commented Jan 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds automated testing of prereleases to Netlify, Vercel, Fly, Cloudflare Pages, Cloudflare Workers, and AWS (via architect).

first and foremost, {target}-prerelease-deployment.test.yml GitHub Action for each target that runs a node script to create a new project on the given target with the name remix-{target}-{sha} and runs a very basic cypress assertion on the dev server and the deployed url.

mcansh added 30 commits January 5, 2022 13:36
@mcansh
test: add netlify prerelease deployment
1a8a491 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: try workflow...
695cc41 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: add package-lock.json
3b42664 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: pass NETLIFY_AUTH_TOKEN to site:create
eacc4f4 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: try workflow...
47f5256 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: NETLIFY_SITE env var isnt working..?
e0f5be5 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: use release ref instead of date
4feb7aa 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: rename netlify workflow
eefe569 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
test: add fly deployment workflow
329f932 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: move FLY_PROJECT_PATH to root env
778b890 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: add arc deployment workflow
1d1d903 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: rename arc workflow
5fe6675 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: update workflow
4a937b2 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: update app name
474cd32 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: install arc cli
8782fdb 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: have arc deploy on prerelease
21f6ed0 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: try fly again
9a16b18 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: update deploy args
fc00438 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: update deploy args
9504a5a 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: update FLY_PROJECT_PATH
64d5d9d 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: update FLY_PROJECT_PATH
5e22c35 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: merge env
3335dbe 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
vercel-prerelease-deployment-test
819a612 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: add token
c06ba1b 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: add token
077163d 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: update url
34c470f 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: token isnt inherited from env
c38bf69 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: use release ref in name
083b14f 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: use sha
ae7105c 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: use sha
2b84a1a 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: only run on prerelease events
006fedc 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh requested a review from kentcdodds January 13, 2022 18:49
mcansh added 2 commits January 13, 2022 16:39
@mcansh
ci: deploy cloudflare workers
e2eaddc 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore(create-remix): add cloudflare-pages to Server type
680400c 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
kentcdodds
kentcdodds requested changes Jan 14, 2022
View reviewed changes

@kentcdodds kentcdodds left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is brilliant! Very well done @mcansh 👏

Just one thing I think either you missed or I misunderstand.

Comment thread .github/workflows/cf-workers-prerelease-deployment.test.yml Outdated
Comment thread scripts/deployment-test/arc.mjs
mcansh added 15 commits January 14, 2022 14:43
@mcansh
ci: worker updates
4f06ab3 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: wrangler publish
dac7dbd 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: fix api token
500f36c 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: use node 16 for cf workers
0945ab2 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: only run on prerelease events
81eb81d 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: deploy to cf pages
757c799 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: configure git
c237d47 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: configure git after initializing repo
07db1ce 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: configure git after initializing repo
2e71c95 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: use main branch
8a4fc69 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: use main branch
e1de2fc 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: oops
98cf87f 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: update sleep log
24e3df1 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: give cypress a url
8de1e6f 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: only run on prerelease events
8fdb6ba 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
kentcdodds
kentcdodds requested changes Jan 14, 2022
View reviewed changes

@kentcdodds kentcdodds left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Just two quick things.

Comment thread .github/workflows/cf-pages-prerelease-deployment.test.yml Outdated
Comment thread scripts/deployment-test/fly-dockerfile Outdated
@mcansh
ci(fly): remove unneeded dockerfile
e1375dc 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh requested a review from kentcdodds January 14, 2022 23:03
kentcdodds
kentcdodds approved these changes Jan 14, 2022
View reviewed changes

@kentcdodds kentcdodds left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome work. Great job Logan. Have a good weekend!

@kentcdodds kentcdodds merged commit c8dc234 into dev Jan 14, 2022
@kentcdodds kentcdodds deleted the logan/rem-656-netlify-prerelease-test branch January 14, 2022 23:43
@ryanflorence ryanflorence mentioned this pull request Jan 15, 2022
Merged
@cmd-johnson

cmd-johnson commented Jan 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi there!
I'm currently working on a PR for getting yarn PnP to work with Remix (#1316). Today I rebased my changes to the current dev branch and the create-remix command no longer works. The prompts all show, but after creating the project directory, the program just exits. Using git bisect, I pinned this down to changes made in this PR. Commit c8dc234 to be precise.

I'm not quite sure what's happening here.
The program runs fine until

remix/packages/create-remix/index.ts

Line 37 in c8dc234

await fse.mkdir(projectDir);
after which it just exits without giving any reason whatsoever.

@cmd-johnson

cmd-johnson commented Jan 20, 2022

Copy link
Copy Markdown
Contributor

Oooooh, I see what's happening
There's an await missing here:

remix/packages/create-remix/cli.ts

Line 104 in c8dc234

createApp({

@kentcdodds

kentcdodds commented Jan 20, 2022

Copy link
Copy Markdown
Member

Thanks for letting us know! We've fixed that now :) Sorry for the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mcansh @cmd-johnson @kentcdodds