Skip to content

fix: warning with vite@8.1.0#15230

Merged
brophdawg11 merged 3 commits into
remix-run:mainfrom
AviVahl:fix-vite-8.1.0-warning
Jun 25, 2026
Merged

fix: warning with vite@8.1.0#15230
brophdawg11 merged 3 commits into
remix-run:mainfrom
AviVahl:fix-vite-8.1.0-warning

Conversation

@AviVahl

@AviVahl AviVahl commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

fixes #15229

the new vite version started warning about this deprecated option being used.

envDir was added in vite@6.3.0, so react-router is safe to use it.

refs:
https://github.com/vitejs/vite/blob/v8.1.0/packages/vite/CHANGELOG.md
vitejs/vite#22555

@remix-cla-bot

remix-cla-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Hi @AviVahl,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

the new vite version started warning about this deprecated option being used.

envDir was added in vite@6.3.0, so react-router is safe to use it.

refs:
https://github.com/vitejs/vite/blob/v8.1.0/packages/vite/CHANGELOG.md
vitejs/vite#22555
@AviVahl AviVahl force-pushed the fix-vite-8.1.0-warning branch from 02916f1 to fb11b45 Compare June 23, 2026 14:42
@remix-cla-bot

remix-cla-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@AviVahl

AviVahl commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

(rebased to sign the CLA)

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

✅ Change File Found

One or more change files found.

Type Change

|

p a t c h

|

R
e
p
l
a
c
e

t
h
e

d
e
p
r
e
c
a
t
e
d

e n v F i l e : f a l s e

V
i
t
e

c
o
n
f
i
g

w
i
t
h

e n v D i r : f a l s e

t
o

e
l
i
m
i
n
a
t
e

a

d
e
p
r
e
c
a
t
i
o
n

w
a
r
n
i
n
g

w
h
e
n

u
s
i
n
g

v
i
t
e
@
8
.
1
.
0
+

|

Comment thread packages/react-router-dev/.changes/patch.fix-envfile-warning-appeared-vite810.md Outdated

@brophdawg11 brophdawg11 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brophdawg11 brophdawg11 self-assigned this Jun 25, 2026
@brophdawg11 brophdawg11 merged commit db526f0 into remix-run:main Jun 25, 2026
13 checks passed
@ryanflorence ryanflorence mentioned this pull request Jun 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hello there,

We recently published version 8.1.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vite@8.1.0: "The envFile option is deprecated, please use envDir: false instead"

2 participants