Skip to content

chore: Explicitly include node types#1282

Merged
eranhirsch merged 1 commit intomainfrom
eranhirsch/fixCanaryLibTypes
Feb 6, 2026
Merged

chore: Explicitly include node types#1282
eranhirsch merged 1 commit intomainfrom
eranhirsch/fixCanaryLibTypes

Conversation

@eranhirsch
Copy link
Member

Blame: microsoft/TypeScript#63054

TypeScript are moving to explicit types instead of catch-all by default. This means that projects need to have a types entry if they want to rely on additional types.

This was surfaced by our canary job on February 5: https://github.com/remeda/remeda/actions/runs/21703126297/job/62587774821

Copilot AI review requested due to automatic review settings February 6, 2026 15:26
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Feb 6, 2026

Deploy Preview for trusting-lumiere-9c7fad ready!

Name Link
🔨 Latest commit 6097205
🔍 Latest deploy log https://app.netlify.com/projects/trusting-lumiere-9c7fad/deploys/69860841aa1b260008f8895f
😎 Deploy Preview https://deploy-preview-1282--trusting-lumiere-9c7fad.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Remeda’s TypeScript configuration to explicitly include Node.js ambient type definitions, aligning with TypeScript’s move toward requiring explicit types opt-ins (as surfaced by the canary job failure).

Changes:

  • Add "types": ["node"] to packages/remeda/tsconfig.json to ensure Node globals/modules are typed during compilation and in editor tooling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4669cd4) to head (6097205).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1282   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          174       174           
  Lines         1622      1622           
  Branches       392       392           
=========================================
  Hits          1622      1622           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 6, 2026

commit: 6097205

@eranhirsch eranhirsch merged commit 20a11e4 into main Feb 6, 2026
45 checks passed
@eranhirsch eranhirsch deleted the eranhirsch/fixCanaryLibTypes branch February 6, 2026 15:30
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

🎉 This PR is included in version 2.33.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants