Update vscode engine#98
Merged
wooorm merged 1 commit intoremarkjs:mainfrom Jul 14, 2022
remcohaszing:update-vscode-engine
Merged
Update vscode engine#98wooorm merged 1 commit intoremarkjs:mainfrom remcohaszing:update-vscode-engine
wooorm merged 1 commit intoremarkjs:mainfrom
remcohaszing:update-vscode-engine
Conversation
It now matches https://github.com/microsoft/vscode-languageserver-node/blob/main/client/src/node/main.ts#L26, which is also the latest version of VS Code at the moment of writing. Because this version of VS Code ships with Node.js 16, the build scripts have been updated to this version as well.
ChristianMurphy
approved these changes
Jul 14, 2022
Member
ChristianMurphy
left a comment
There was a problem hiding this comment.
LGTM,
a broader question, how to we want to handle VSCode version support in relationship to this module's own version?
Would this be considered semver major for vscode-remark?
Member
Author
|
Semver has a clear meaning for libraries. For user facing software such as a VSCode plugin, it’s not as meaningful. IMO the upcoming release will be major, because the extension has pretty much been rewritten from scratch, but I’m not sure how to deal with future versions. |
wooorm
approved these changes
Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
It now matches https://github.com/microsoft/vscode-languageserver-node/blob/main/client/src/node/main.ts#L26, which is also the latest version of VS Code at the moment of writing.
Because this version of VS Code ships with Node.js 16, the build scripts have been updated to this version as well.