Add language for .remarkrc, .remarkignore to VSC#78
Merged
wooorm merged 2 commits intoremarkjs:mainfrom Dec 23, 2021
remcohaszing:define-config-languages
Merged
Add language for .remarkrc, .remarkignore to VSC#78wooorm merged 2 commits intoremarkjs:mainfrom remcohaszing:define-config-languages
.remarkrc, .remarkignore to VSC#78wooorm merged 2 commits intoremarkjs:mainfrom
remcohaszing:define-config-languages
Conversation
This comment has been minimized.
This comment has been minimized.
Comment on lines
+220
to
+233
| "languages": [ | ||
| { | ||
| "id": "ignore", | ||
| "extensions": [ | ||
| ".remarkignore" | ||
| ] | ||
| }, | ||
| { | ||
| "id": "json", | ||
| "filenames": [ | ||
| ".remarkrc" | ||
| ] | ||
| } | ||
| ] |
Member
There was a problem hiding this comment.
This is new-ish to me.
Does this only impact people cloning this repo?
Or does this somehow tell vscode how to highlight these files if remark is installed?
Member
Author
There was a problem hiding this comment.
This is part of the plugin manifest, not local development settings.
Or does this somehow tell vscode how to highlight these files if remark is installed?
☝️ This exactly
I basically copied it from https://github.com/microsoft/vscode-eslint/blob/main/package.json#L490-L503
Member
There was a problem hiding this comment.
Interpreting the :+1: by Christian as an ✅ review
wooorm
approved these changes
Dec 23, 2021
.remarkrc, .remarkignore to VSC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
These languages can’t be detected by VSCode by default.