Skip to content

Configure Renovate#30

Merged
ChristianMurphy merged 2 commits intomasterfrom
renovate/configure
Nov 29, 2020
Merged

Configure Renovate#30
ChristianMurphy merged 2 commits intomasterfrom
renovate/configure

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Sep 8, 2020

WhiteSource Renovate

Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.

🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.


Detected Package Files

  • .github/workflows/build.yml (github-actions)
  • package.json (npm)

Configuration

🔡 Renovate has detected a custom config for this PR. Feel free to ask for help if you have any doubts and would like it reviewed.

Important: Now that this branch is edited, Renovate can't rebase it from the base branch any more. If you make changes to the base branch that could impact this onboarding PR, please merge them manually.

What to Expect

With your current configuration, Renovate will create 5 Pull Requests:

chore(deps): update dependency eslint to v7
  • Schedule: ["at any time"]
  • Branch name: renovate/eslint-7.x
  • Merge into: master
  • Upgrade eslint to ^7.0.0
chore(deps): update dependency mocha to v8
  • Schedule: ["at any time"]
  • Branch name: renovate/mocha-8.x
  • Merge into: master
  • Upgrade mocha to ^8.0.0
  • Upgrade @types/mocha to ^8.0.0
chore(deps): update dependency typescript to v4
  • Schedule: ["at any time"]
  • Branch name: renovate/typescript-4.x
  • Merge into: master
  • Upgrade typescript to ^4.0.0
chore(deps): update typescript-eslint monorepo to v4 (major)
fix(deps): update dependency remark to v13
  • Schedule: ["at any time"]
  • Branch name: renovate/major-remark-monorepo
  • Merge into: master
  • Upgrade remark to ^13.0.0

🚸 Branch creation will be limited to maximum 2 per hour, so it doesn't swamp any CI resources or spam the project. See docs for prhourlylimit for details.


❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section.
If you need any further assistance then you can also request help here.


This PR has been generated by WhiteSource Renovate. View repository job log here.

@ChristianMurphy ChristianMurphy linked an issue Sep 8, 2020 that may be closed by this pull request
@wooorm
Copy link
Member

wooorm commented Sep 8, 2020

@ChristianMurphy The types/node update has no effect whatsoever. Can we do without such changes?

@ChristianMurphy
Copy link
Member

ChristianMurphy commented Sep 8, 2020

This is the base configuration, the description of what that entails is above.
A couple notable tweaks that other projects have made: scheduling PRs to reduce noise and not pinning dev dependencies also to reduce noise

The types/node update has no effect whatsoever. Can we do without such changes?

They can impact typescript validation.
Packages and/or groups of packages can be disabled, but there are a lot of noise reducation techniques which could also be explored https://docs.renovatebot.com/noise-reduction

@wooorm
Copy link
Member

wooorm commented Sep 8, 2020

It could, but it shouldn't according to semver tho?

Re noise reduction: I'm up for all of those mechanisms 😅

@ChristianMurphy
Copy link
Member

ChristianMurphy commented Sep 8, 2020

It could, but it shouldn't according to semver tho?

Sometimes.
Like most libraries, if part of it is exported in the public API, yes, it falls under SemVer.
If it's used for internal validation only, it isn't necessarily covered by SemVer.

In the case of VSCode plugins, I don't thing the types are part of the public API.

@wooorm
Copy link
Member

wooorm commented Sep 8, 2020

It’s a dev-dep here: so it shouldn’t be exposed in any way. I get what you mean if it were a direct dep though

@asbjornu
Copy link
Collaborator

Is this good to go?

@ChristianMurphy ChristianMurphy merged commit 078289c into master Nov 29, 2020
@ChristianMurphy ChristianMurphy deleted the renovate/configure branch November 29, 2020 19:38
@renovate
Copy link
Contributor Author

renovate bot commented Jul 15, 2022

Renovate is disabled

Renovate is disabled because there is no Renovate configuration file. To enable Renovate, you can either (a) change this PR's title to get a new onboarding PR, and merge the new onboarding PR, or (b) create a Renovate config file, and commit that file to your base branch.

@asbjornu
Copy link
Collaborator

asbjornu commented Jul 18, 2022

I can see that renovate.json was removed by @remcohaszing in #108, without any clear explanation of why other than "we don't really use it". Is it a Unified policy to not keep packages up to date, or that it needs to be a manual task or something else? @ChristianMurphy @wooorm

@ChristianMurphy
Copy link
Member

It is unified convention to use wide version ranges so that updates happen largely automatically, without need for a bot.
When the updates happen, they generally happen in batches with major version changes which require manual intervention anyway.

@asbjornu
Copy link
Collaborator

asbjornu commented Jul 18, 2022

I see. That makes sense for NPM packages, but what about GitHub Actions and such? I would still like #90 and #91 to be submitted automatically.

@wooorm
Copy link
Member

wooorm commented Jul 19, 2022

Actions don’t change frequently, and like other dev-dependencies, it is less important to update right when new majors are released.

@asbjornu
Copy link
Collaborator

Sure, but I don't manually follow up on when all of the GitHub Actions in all of my repositories release a new version. I expect a tool to convey that information to me, without me having to lift a finger. How can we achieve that?

@wooorm
Copy link
Member

wooorm commented Jul 20, 2022

I don’t think we need to achieve that.
Renovate wasn‘t used here and it was noisy.

@asbjornu
Copy link
Collaborator

Renovate was absolutely used and many of its pull requests were merged. I’ll leave it to you to keep all dependencies up to date, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Set up Dependabot

4 participants