refactor: use fs' built in promise support#25
Merged
asbjornu merged 2 commits intoremarkjs:masterfrom Sep 8, 2020
Merged
Conversation
BarryThePenguin
approved these changes
Sep 7, 2020
Member
BarryThePenguin
left a comment
There was a problem hiding this comment.
Only thing I'd consider changing is moving .toString() to each usage of content
Otherwise looks good 👀
b1ac57c to
91562b5
Compare
Member
Author
Good idea, refactored in 91562b5 |
wooorm
approved these changes
Sep 8, 2020
asbjornu
requested changes
Sep 8, 2020
asbjornu
approved these changes
Sep 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://nodejs.org/api/fs.html#fs_filehandle_readfile_options