types: use typings provided by remark#24
Merged
asbjornu merged 1 commit intoremarkjs:masterfrom Sep 2, 2020
Merged
Conversation
ChristianMurphy
commented
Sep 1, 2020
| let message = ''; | ||
|
|
||
| result.messages.forEach((value: string) => { | ||
| result.messages.forEach((value) => { |
asbjornu
reviewed
Sep 1, 2020
Collaborator
asbjornu
left a comment
There was a problem hiding this comment.
This looks good, but if you have ideas for how to exercise the touched code in a test so we know for a fact that it works, that would be awesome!
Member
Author
This corrects the typing, which is tested by Additional unit tests are wonderful, but would likely be out of scope of a typing fix. (?) |
Collaborator
Ok, fair enough. |
Collaborator
|
Thanks, @ChristianMurphy! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with remark version 11, remark has provided typings as part of the package.