Merged
Conversation
Log workspace name and assert that the config should not be null
Split `getWorkspaceConfig()` and `parseWorkspaceConfig()` so the latter one can be tested simply by passing in a path to the `.remarkrc` file we want to test.
Move the `test` directory underneath the `test` directory in `src` and rename it to `json`.
7821b88 to
b749c0d
Compare
Collaborator
Author
|
@mrmlnc, this is now rebased against the |
Collaborator
|
I gave you the rights to manage the repository (includes merge of PR's). |
Collaborator
Author
|
Excellent, thanks, @mrmlnc. If you want me to follow up on remarkjs/remark#508 (comment), perhaps you can make me an admin of the repository? Seeing how I'm going to have that after the repository is moved anyway, I might as well have it now, no? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a GitHub Actions workflow that performs extensive tests on the parsing of
.remarkrcin preparation for a fix for #15. Without a continuous integration system with automatic tests, it's hard to debug and fix problems. This PR tries to remedy that.The PR also upgrades the entire extension to be on par with the current Yeoman template, which was the only way I was able to get the automatic tests to work.
I can also warmly recommend that you set up Dependabot to keep all dependencies in this extensions up to date. It's free and creates pull requests with changes to
package.jsonandpackage-lock.jsonwhenever a dependency has a new version. It's also highly configurable so you can ignore minor versions, major versions, whole packages, etc.