Skip to content

Add rel tag to links#350

Closed
juancarlosqr wants to merge 1 commit intoremarkjs:masterfrom
juancarlosqr:add-link-rel-tag
Closed

Add rel tag to links#350
juancarlosqr wants to merge 1 commit intoremarkjs:masterfrom
juancarlosqr:add-link-rel-tag

Conversation

@juancarlosqr
Copy link

@juancarlosqr juancarlosqr commented Oct 5, 2019

Hi,

For security reasons external links should be able to have a rel tag (.e.g. "noopener noreferrer"). More info here

I created a linkRel option to add the tag, similar to linkTarget

This is the first year I participate in the Hacktoberfest, so I'm open to any comments or feedback regarding my contribution 😉

Happy Hacktoberfest!

@blaiz
Copy link

blaiz commented Dec 3, 2019

This looks great! I also have a need for this prop. Hopefully this can be merged soon.

@benliger1987
Copy link

benliger1987 commented Feb 3, 2020

Any progress on merging this? Seems like a pretty crucial commit security wise

@fivetwelve
Copy link

fivetwelve commented Feb 12, 2020 •
edited
Loading

Would be nice to be able to add optionally nofollow value in addition to those base ones.

@mxmtsk mxmtsk mentioned this pull request Apr 9, 2020
Closed
@fdidron fdidron mentioned this pull request Apr 30, 2020
Closed
This was referenced Jun 29, 2020
Open
Closed
@wchargin
Copy link

wchargin commented Jun 29, 2020

@rexxars: Friendly ping :-) if you get a chance to look at this, that’d
be lovely, since it enables fixing a security hole. It looks like the PR
still merges cleanly into origin/master, and the proposed patch looks
nice and clean.

@madhums
Copy link

madhums commented Jul 7, 2020

Can anyone merge this and do a release? Seems like an important fix!

@fcsonline
Copy link

fcsonline commented Sep 18, 2020

Can this be merged? Is something blocking it?

@juancarlosqr
Copy link
Author

juancarlosqr commented Sep 23, 2020

@fcsonline no blocker, the repo looks like is not maintained anymore :( any comment @rexxars?

@wooorm
Copy link
Member

wooorm commented Oct 8, 2020

You can use a plugin for that: https://github.com/remarkjs/remark-external-links

@wooorm wooorm closed this Oct 8, 2020
@wooorm wooorm added the 👀 no/external This makes more sense somewhere else label Oct 8, 2020
@wooorm wooorm mentioned this pull request Oct 8, 2020
Closed
@2manyvcos
Copy link

2manyvcos commented Oct 9, 2020 •
edited
Loading

@wooorm That would be a preferable solution.
However, like stated in this comment, the suggested plugin sadly does not seem to work with react-markdown.

I just tried it but without success.

EDIT: NVM I just saw your other comment here

@wooorm
Copy link
Member

wooorm commented Oct 9, 2020

there’s a PR merged that solves that which will be released soon

@juancarlosqr juancarlosqr deleted the add-link-rel-tag branch October 9, 2020 13:43
@adarnon
Copy link

adarnon commented Oct 27, 2020

Has anyone managed to get remark-external-links to work? The new version has been released, but it looks like the plugin just isn't run.

@MorelSerge
Copy link

MorelSerge commented Jan 14, 2021

@adarnon I haven't been able to on 5.0.3

@wassim
Copy link

wassim commented Jan 30, 2021

remark-external-links still doesn't work... @wooorm please reopen the issue!

@statico
Copy link

statico commented Aug 2, 2021

As of August, 2021, remark-external-links seems to work fine.

@wooorm wooorm mentioned this pull request Aug 24, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

👀 no/external This makes more sense somewhere else

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.