fix(types): fix Type error: ',' expected. in index.d.ts#879
Merged
remarkablemark merged 1 commit intomasterfrom Mar 24, 2023
Merged
fix(types): fix Type error: ',' expected. in index.d.ts#879remarkablemark merged 1 commit intomasterfrom
Type error: ',' expected. in index.d.ts#879remarkablemark merged 1 commit intomasterfrom
Conversation
Contributor
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #879 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 174 174
Branches 58 58
=========================================
Hits 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
fix(types): fix
Type error: ',' expected.in index.d.tsFixes #871
What is the current behavior?
Some TypeScript users are getting the error:
This is caused by module and type imports from 'domhandler' being combined into one.
What is the new behavior?
Separated module and type imports.
Checklist: