fix(attributes-to-props): don't convert non-uncontrolled component props#852
Merged
remarkablemark merged 2 commits intomasterfrom Mar 4, 2023
Merged
fix(attributes-to-props): don't convert non-uncontrolled component props#852remarkablemark merged 2 commits intomasterfrom
remarkablemark merged 2 commits intomasterfrom
Conversation
Contributor
size-limit report 📦
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #852 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 172 174 +2
Branches 58 58
=========================================
+ Hits 172 174 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Package size limit has exceeded by 7 B Size limit: 10.59 kB Size: 10.6 kB with all dependencies, minified and gzipped Loading time: 208 ms on slow 3G Running time: 76 ms on Snapdragon 410 Total time: 283 ms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
fix(attributes-to-props): don't convert non-uncontrolled component props
Fixes #839
What is the current behavior?
Non-uncontrolled component (e.g.,
<li>) attributes likevalueare being converted todefaultValuewhich is incorrectWhat is the new behavior?
Only uncontrolled components have attributes
checkedandvalueconverted:<input><select><textarea>Non-uncontrolled components are ignored
Checklist: