fix: ensure backwards compatibility for html-dom-parser's ES Module#446
Merged
remarkablemark merged 2 commits intomasterfrom Feb 6, 2022
Merged
fix: ensure backwards compatibility for html-dom-parser's ES Module#446remarkablemark merged 2 commits intomasterfrom
remarkablemark merged 2 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #446 +/- ##
============================================
+ Coverage 74.26% 100.00% +25.73%
============================================
Files 8 8
Lines 136 167 +31
Branches 35 57 +22
============================================
+ Hits 101 167 +66
+ Partials 35 0 -35
Continue to review full report at Codecov.
|
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #445
What is the motivation for this pull request?
fix: support backwards compatibility for
html-dom-parser's ES ModuleRegression was caused in 1.4.7. Related to remarkablemark/html-dom-parser#202
What is the current behavior?
next@10 throws an error:
Note: next@11 and 12 did not have this error
What is the new behavior?
No error in next@10
Checklist: