fix: trim only when necessary if trimming is off by vidhu · Pull Request #394 · remarkablemark/html-react-parser

vidhu · 2021-12-14T05:32:08Z

Fixes #384

What is the motivation for this pull request?

Fixes an issue #384 where trimming can lead to inaccurate parsing when nodes have whitespace characters

What is the current behavior?

if trim is off, whitespace characters trigger reacts validation errors
if trim is on, whitespaces are stripped from nodes that can contain white spaces which results in inaccurate parsing

What is the new behavior?

Regardless of the trimming setting, if a text node appears in a node that can contain text nodes eg <table>, <tr>, it will be removed. If trimming is off, then whitespaces are preserved in nodes that can contain text nodes.

Checklist:

Conventional Commits
Tests
Documentation
Types

Looking for approvals before I add to documentation!

lib/dom-to-react.js

codecov-commenter · 2021-12-15T02:43:31Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ec61f9e) to head (4126592).
⚠️ Report is 2127 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master      #394   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          158       162    +4     
  Branches        55        54    -1     
=========================================
+ Hits           158       162    +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lib/utilities.js

test/index.test.js

test/utilities.test.js

lib/dom-to-react.js

remarkablemark

Left comments

vidhu · 2021-12-15T05:30:18Z

Left comments

Thank you! I've resolved the ones I've fixed and replied to your other comments

lib/utilities.js

remarkablemark

Looks good! Will you be updating docs @vidhu?

vidhu · 2021-12-16T04:46:40Z

Looks good! Will you be updating docs @vidhu?

Yes! Just pushed out a commit to update the docs.

README.md

remarkablemark

Left comments

vidhu · 2021-12-18T05:11:21Z

Thank you @remarkablemark I've addressed your requested changes

remarkablemark

Thanks, looks good @vidhu!

remarkablemark · 2021-12-18T06:35:47Z

Released in #395 (comment)

vidhu · 2021-12-20T15:59:43Z

Thank you! Pleasure working with you :)

remarkablemark · 2021-12-20T21:09:14Z

Same here! @vidhu If you're ever interested in being a maintainer for html-react-parser, I'd be happy to extend the offer.

vidhu · 2021-12-21T16:05:17Z

Thank you. I would be interested in that. Do you use any instant messaging platform like discord?

remarkablemark · 2021-12-21T17:44:16Z

Yes! We have a Discord server, feel free to DM me once you join

vidhu added 2 commits December 14, 2021 00:12

fix(dom-to-react): trim whitespaces if it is not valid in parent

523e292

test(utilities): tests for canTextBeChildOfNode

5cbcac8

vidhu mentioned this pull request Dec 14, 2021

Only trim nodes if parent can't contain text nodes #384

Closed

vidhu changed the title ~~Fix/trimming issue~~ Trim only when necessary if timing is off Dec 14, 2021

vidhu changed the title ~~Trim only when necessary if timing is off~~ Trim only when necessary if trimming is off Dec 14, 2021