fix(attributes-to-props): convert attribute to uncontrolled component prop#388
Merged
remarkablemark merged 2 commits intomasterfrom Dec 13, 2021
Merged
fix(attributes-to-props): convert attribute to uncontrolled component prop#388remarkablemark merged 2 commits intomasterfrom
remarkablemark merged 2 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 154 158 +4
Branches 54 55 +1
=========================================
+ Hits 154 158 +4
Continue to review full report at Codecov.
|
Contributor
size-limit report 📦
|
Owner
Author
|
Released in #389 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #321
What is the motivation for this pull request?
fix(attributes-to-props): convert attribute to uncontrolled component prop
What is the current behavior?
HTML DOM attributes (
checkedandvalue) are rendered as controlled components:checked->checkedvalue->valueWhat is the new behavior?
HTML DOM attributes (
checkedandvalue) are rendered as uncontrolled components:checked->defaultCheckedvalue->defaultValueChecklist: