fix(utilities): skip invalid style attributes#257
Merged
remarkablemark merged 4 commits intoremarkablemark:masterfrom Aug 12, 2021
Merged
fix(utilities): skip invalid style attributes#257remarkablemark merged 4 commits intoremarkablemark:masterfrom
remarkablemark merged 4 commits intoremarkablemark:masterfrom
Conversation
remarkablemark
requested changes
Jun 12, 2021
Owner
remarkablemark
left a comment
There was a problem hiding this comment.
@dogriffiths Thanks for opening this PR!
It looks good overall. I left some comments and can you fix lint errors?
npm run lint:fix
Owner
|
Also, do you think the README should be updated? |
Owner
|
@dogriffiths would you be able to help get the build green so I can move this PR forward? |
remarkablemark
approved these changes
Aug 12, 2021
Owner
remarkablemark
left a comment
There was a problem hiding this comment.
LGTM, thanks for working on this @dogriffiths!
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #256
What is the motivation for this pull request?
What is the current behavior?
What is the new behavior?
Checklist: