fix(dom-to-react): transform style to object for Web Components#193
Merged
remarkablemark merged 1 commit intomasterfrom Dec 12, 2020
Merged
fix(dom-to-react): transform style to object for Web Components#193remarkablemark merged 1 commit intomasterfrom
remarkablemark merged 1 commit intomasterfrom
Conversation
sinchang
approved these changes
Dec 12, 2020
Owner
Author
|
This is still an issue at 1.2.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
fix(dom-to-react): transform style to object for Web Components
Fixes #188
What is the current behavior?
Web Components skip the
attributesToPropsprocess. However, React still expects the custom elementstyleprop to be an object and not a string:What is the new behavior?
Web Components will only get the
styleattribute transformed into an object.Checklist: