feat: export attributesToProps#174
Merged
remarkablemark merged 2 commits intoremarkablemark:masterfrom Sep 11, 2020
Merged
Conversation
2c89e45 to
00fbef2
Compare
remarkablemark
requested changes
Sep 10, 2020
Owner
remarkablemark
left a comment
There was a problem hiding this comment.
Looks good! Can you also update the README.md documentation with an applicable example of attributesToProps?
Contributor
Author
ok |
remarkablemark
approved these changes
Sep 11, 2020
Owner
remarkablemark
left a comment
There was a problem hiding this comment.
Looks good to me! 多谢 @cbbfcd
Owner
Contributor
Author
|
@remarkablemark 哈哈哈哈，客气 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
Sometimes we need custom the replacer, and so we maybe need the attributesToProps too.
Closes #172
What is the current behavior?
Users need to implement it themselves
What is the new behavior?
just require the
attributesToPropsfunctionChecklist: