Skip to content

test: migrate from mocha to jest#164

Merged
remarkablemark merged 11 commits intomasterfrom
test/jest
Jun 15, 2020
Merged

test: migrate from mocha to jest#164
remarkablemark merged 11 commits intomasterfrom
test/jest

Conversation

@remarkablemark
Copy link
Copy Markdown
Owner

@remarkablemark remarkablemark commented Jun 15, 2020 •
edited
Loading

What is the motivation for this pull request?

test: migrate from Mocha to Jest

What is the current behavior?

Tests are run using Mocha

What is the new behavior?

Tests are run using Jest

Checklist:

  • Tests

@remarkablemark
test: migrate from mocha to jest
48099c1 
Update package.json devDependencies:

```diff
+jest
-mocha
-nyc
```

Update package.json scripts and remove `test:coverage:report`

Run `jest-codemods` (https://jestjs.io/docs/en/migration-guide):

```sh
jscodeshift -t jest-codemods/dist/transformers/mocha.js . --ignore-pattern node_modules --parser babel
```

Rename files under `test` directory

Update eslint, husky, travis, and tsconfig
@remarkablemark
test(dom-to-react): refactor react tests to snapshot tests
5077d69
@remarkablemark
test(dom-to-react): refactor to use expect instead of assert
9f4a9fd
@remarkablemark
test(attributes-to-props): refactor to expect instead of assert
6e74b50
@remarkablemark
test(html-to-react): refactor to expect instead of assert
550b2ae
@remarkablemark
test(utilities): refactor to expect instead of assert
29a3230
@remarkablemark
test(helpers): refactor data.json to data.js
da1e89c
@remarkablemark
test(helpers): refactor render method
9cb48ed 
This brings test coverage back to 100%
@remarkablemark
test(html-to-react): refactor forEach to it.each
6bf3526 
And add more test cases
@remarkablemark
test(utilities): refactor forEach to it.each and add more cases
4c64bb3
@remarkablemark
chore(package): add script test:ci; update husky, travis, publish
e7c5079 
`npm run test:ci` passes option `--ci` to `npm test`, which fails
the test if a new snapshot is encountered.
@remarkablemark remarkablemark merged commit 3a2f26e into master Jun 15, 2020
@remarkablemark remarkablemark deleted the test/jest branch June 15, 2020 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@remarkablemark