Skip to content

build(package): upgrade react from 18 to 19 in devDependencies#1629

Closed
remarkablemark wants to merge 1 commit into
masterfrom
build/package
Closed

build(package): upgrade react from 18 to 19 in devDependencies#1629
remarkablemark wants to merge 1 commit into
masterfrom
build/package

Conversation

@remarkablemark

Copy link
Copy Markdown
Owner

What is the motivation for this pull request?

build(package): upgrade react from 18 to 19 in devDependencies

What is the current behavior?

Jest tests run on React 18

What is the new behavior?

Jest tests run on React 19

Checklist:

@remarkablemark remarkablemark added the dependencies Pull requests that update a dependency file label Dec 6, 2024
@remarkablemark remarkablemark self-assigned this Dec 6, 2024
@github-actions

github-actions Bot commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-react-parser.min.js 9.45 KB (0%) 189 ms (0%) 55 ms (+955.68% 🔺) 244 ms

@remarkablemark

remarkablemark commented Dec 6, 2024

Copy link
Copy Markdown
Owner Author
Error: expect(received).toMatchSnapshot()

Snapshot name: `domToReact converts single DOM node to React 1`

- Snapshot  -  3
+ Received  + 10

- <p>
-   foo
- </p>
+ {
+   "$$typeof": Symbol(react.transitional.element),
+   "_owner": null,
+   "_store": {},
+   "key": null,
+   "props": {
+     "children": "foo",
+   },
+   "type": "p",
+ }

    at Object.<anonymous> (__tests__/dom-to-react.test.tsx:24:26)

Screenshot 2024-12-05 at 8 14 43 PM

See jestjs/jest#15402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant