Skip to content

test: refactor and add missing tests, get coverage to 100%#156

Merged
remarkablemark merged 5 commits intomasterfrom
test/coverage
May 25, 2020
Merged

test: refactor and add missing tests, get coverage to 100%#156
remarkablemark merged 5 commits intomasterfrom
test/coverage

Conversation

@remarkablemark
Copy link
Copy Markdown
Owner

@remarkablemark remarkablemark commented May 25, 2020 •
edited
Loading 

-------------------------|----------|----------|----------|----------|-------------------|
File                     |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
-------------------------|----------|----------|----------|----------|-------------------|
All files                |      100 |    97.85 |      100 |      100 |                   |
 html-react-parser       |      100 |      100 |      100 |      100 |                   |
  index.js               |      100 |      100 |      100 |      100 |                   |
 html-react-parser/lib   |      100 |     97.8 |      100 |      100 |                   |
  attributes-to-props.js |      100 |    95.65 |      100 |      100 |                85 |
  dom-to-react.js        |      100 |    97.44 |      100 |      100 |                38 |
  utilities.js           |      100 |      100 |      100 |      100 |                   |
-------------------------|----------|----------|----------|----------|-------------------|

@remarkablemark
test: tidy tests, replace assert.equal with assert.strictEqual
ef04eff
@remarkablemark
test(attributes-to-props): test that CSS comment is not parsed
0c27987 
This helps improve test coverage for `attributes-to-props.js`.

Move empty style test to its own it block.
@remarkablemark
refactor(attributes-to-props): remove string type check in cssToJs
77a108b 
Since it does not provide any value as style is either undefined,
null, or string.
@remarkablemark
test(dom-to-react): tidy tests and add case for single node replace
452f6be 
This gets coverage to 100%.
@coveralls
Copy link
Copy Markdown

coveralls commented May 25, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling aeed1bf on test/coverage into d299826 on master.

@remarkablemark
ci(travis): move coveralls script from package.json to .travis.yml
aeed1bf 
Use `npx` so we can remove `coveralls` from devDependencies
@remarkablemark remarkablemark merged commit 74931e4 into master May 25, 2020
@remarkablemark remarkablemark deleted the test/coverage branch May 25, 2020 22:46
@remarkablemark
Copy link
Copy Markdown
Owner Author

remarkablemark commented May 25, 2020

Published 0.10.4:

npm:

npm i html-react-parser@0.10.4 -S

yarn:

yarn add html-react-parser@0.10.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@remarkablemark @coveralls