fix: use JSX.Element for type definitions#146
Merged
remarkablemark merged 2 commits intoremarkablemark:masterfrom Mar 28, 2020
Merged
fix: use JSX.Element for type definitions#146remarkablemark merged 2 commits intoremarkablemark:masterfrom
remarkablemark merged 2 commits intoremarkablemark:masterfrom
Conversation
Owner
remarkablemark
left a comment
There was a problem hiding this comment.
@yunyu Thanks for opening this PR! Overall, it looks good. I left some minor/nitpick comments. Let me know what you think.
49c8822 to
bae05c0
Compare
Contributor
Author
|
@remarkablemark I've made the requested changes |
remarkablemark
approved these changes
Mar 28, 2020
Owner
remarkablemark
left a comment
There was a problem hiding this comment.
LGTM, thanks for making the changes @yunyu!
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
This makes the library usable for non-React JSX implementations in TypeScript. JSX.Element is defined as React.ReactElement for the 'react' package, and is overridden by other JSX implementations. Fixes #145.
What is the current behavior?
Currently, trying to use html-react-parser with Preact in TS will result in a bunch of type errors.
What is the new behavior?
Checklist: